2 KiB
2 KiB
title | date | weight | subsection |
---|---|---|---|
Contribution Checklist | 2017-08-20T12:33:36-04:00 | 1 | Getting Started |
Thanks for your interest in contributing code!
Follow this checklist for submitting a pull request (PR):
- You've signed the Contributor License Agreement, so you can be added to the Mattermost Approved Contributor List.
- Your ticket is a Help Wanted GitHub issue for the project you're contributing to.
- If not, follow the process here.
- Your code is thoroughly tested, including appropriate unit tests, and manual testing.
- If applicable, user interface strings are included in the localization file (en.json)
- In the webapp folder, run
npm run i18n-extract
to generate the new/updated strings.
- In the webapp folder, run
- The PR is submitted against the
main
branch from your fork. - The PR title begins with the GitHub Ticket ID (e.g.
[GH-394]
) and the summary template is filled out.
Once submitted, the automated build process must pass in order for the PR to be accepted. Any errors or failures need to be addressed in order for the PR to be accepted. Next, the PR goes through code review. To learn about the review process for each project, read the CONTRIBUTING.md
file of that GitHub repository.