* Adding confirmation modal when setting the board to public with Editor or Commenter role
* Applying suggested text changes
* Update webapp/i18n/en.json
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* Update webapp/i18n/en.json
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* Update webapp/src/components/shareBoard/teamPermissionsRow.tsx
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* update text to match
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* fix: no implicit (synthetic) memberships for guest
* fix: only check if guest if no explicit member
* refactor: join() to select() non-guest users
* style: golant lint
* fix: search as guest only returns explicit boards
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* retrieve all team members for specific lists
* retrieve all team members for specific lists
* final fixes
* update to use enum
* unit test fixes
* lint fixes
* fix integration test
* fixup integration test
* fix issues with making board private
* update to make webapp and server enums match
* fix to add member in correct role
* remove unnecessary property, check Open/Private board
* cleanup confirm for non admin
* some final cleanup
* move default to webapp
* only allow greater roles in drop down, change property name to minimumRole
* update multiperson property to confirm and select same as person property
* implement hashing of keys to cause Select to reprocess initial load
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* retrieve all team members for specific lists
* retrieve all team members for specific lists
* final fixes
* update to use enum
* unit test fixes
* lint fixes
* fix integration test
* fixup integration test
* fix issues with making board private
* update to make webapp and server enums match
* fix to add member in correct role
* remove unnecessary property, check Open/Private board
* cleanup confirm for non admin
* some final cleanup
* move default to webapp
* only allow greater roles in drop down, change property name to minimumRole
* update z-index label, incorrect one used
* revert margin change
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* retrieve all team members for specific lists
* retrieve all team members for specific lists
* final fixes
* update to use enum
* unit test fixes
* lint fixes
* fix integration test
* fixup integration test
* fix issues with making board private
* update to make webapp and server enums match
* fix to add member in correct role
* remove unnecessary property, check Open/Private board
* cleanup confirm for non admin
* some final cleanup
* move default to webapp
* only allow greater roles in drop down, change property name to minimumRole
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Showing unknown channel and on share board modals if channel is no longer accessible
* uncomment tests, write snapshots
* update snapshot
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* fix: display non-explicit members in share select
* Update webapp/src/components/shareBoard/shareBoard.tsx
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
* Enabling again the eslint rules and applying the fixes
* Restore , separators for types in single line mode
* fix new errors
* more lint fixes
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
* Check on GetBoardsForUserAndTeam if the board result list is incomplete and continue if that's the case
* Remove template filter and correctly check for not founds
* Update board store to return inserted / patched values without querying the DB after modifying them
* Remove redundant condition check after error refactoring
* Refactor error usage from the store level up and add API helpers
* Complete API tests
* Fix merge errorResponse calls
* Remove ensure helpers to allow for custom messages on permission errors
* Fix bad import and call
* Remove bad user check on auth that was added as part of the main merge
* Fix empty list test
* Replace deprecated proxy calls to ioutil.ReadAll with io.ReadAll
* Add information to the NotFound errors
* Add context to all remaining errors and address review comments
* Fix linter
* Adapt the new card API endpoints to the error refactor
* Remove almost all customErrorResponse calls
* Add request entity too large to errorResponse and remove customErrorResponse
* Fix linter
