luisgulo/focalboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix broken main store.getBoardsInTeamByIds (#3840)

Browse source 
* fix broken main GetBoardsForUserAndTeam

* comment unit tests
This commit is contained in:
Doug Lauder 2022-09-14 05:27:36 -04:00 committed by GitHub
parent dfb9656fbe
commit 6f35ed8678
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
server/services/store/sqlstore/board.go
View file

@ -295,7 +295,14 @@ func (s *SQLStore) getBoardsInTeamByIds(db sq.BaseRunner, boardIDs []string, tea
}
if len(boards) != len(boardIDs) {
return boards, model.NewErrNotAllFound("board", boardIDs)
s.logger.Warn("getBoardsInTeamByIds mismatched number of boards found",
mlog.Int("len(boards)", len(boards)),
mlog.Int("len(boardIDs)", len(boardIDs)),
)
// ToDo: Don't return an error until the query above is fixed to return exactly the same
// number of boards as the ids passed in.
// Wiggin77 thinks the ids list includes templates and this query does not.
// return boards, model.NewErrNotAllFound("board", boardIDs)
}
return boards, nil

2
server/services/store/storetests/boards.go
View file

@ -242,6 +242,7 @@ func testGetBoardsInTeamByIds(t *testing.T, store store.Store) {
ExpectedError bool
ExpectedLen int
}{
/* ToDo: uncomment when getBoardsinTeamsByIds is fixed
{
Name: "if none of the IDs are found",
BoardIDs: []string{"nonexistent-1", "nonexistent-2"},
@ -254,6 +255,7 @@ func testGetBoardsInTeamByIds(t *testing.T, store store.Store) {
ExpectedError: true,
ExpectedLen: 1,
},
*/
{
Name: "if all of the IDs are found",
BoardIDs: []string{"board-id-1", "board-id-2"},