Commit Graph

927 Commits

Author SHA1 Message Date
Julien Fabre
74a3c63ddc
chore: add tests unit on emptycardbutton (#1458) 2021-10-06 13:09:43 -06:00
Miguel de la Cruz
85ccc051ec
Adds a check to ensure that the URL view belongs to the board or redirects (#1468)
* Adds a check to ensure that the URL view belongs to the board or redirects

* Fix linter
2021-10-06 18:57:52 +02:00
Miguel de la Cruz
ee3f00858a
Move app history replace to happen only if not in plugin legacy mode (#1466) 2021-10-06 17:55:19 +02:00
Scott Bishel
d0dd6ad31a
only call history replace if a plugin (#1457)
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-06 08:27:44 -06:00
Scott Bishel
e18ecc3be2
make sure setValue receives empty string (#1444)
* make sure setValue receives empty string

* fix lint errors
2021-10-06 07:57:16 -06:00
Harshil Sharma
7ca76b9db1
Avoided boards from navigating to URL not belonging to it (#1460) 2021-10-06 14:11:47 +05:30
Tiago Santos Da Silva
e0935eb15c
Typing adjustment - 1353 (#1415)
* refactor: adjusting typing

* fix: improving typing

* refactor: simplifying typing using Generics
2021-10-05 16:55:55 -06:00
Julien Fabre
a594714d92
[GH-859] Add tests unit for filterComponent (#1445)
* chore[GH-#859]: add tests unit for filterComponent

* chore: add test on is empty filterEntry
2021-10-05 13:08:51 -04:00
Doug Lauder
4feafb9806
Channels style UUID (#1369)
* server channels style uuids
* webapp channels style uuids
2021-10-05 09:52:59 -04:00
Julien Fabre
596332e5f7
chore[GH-#860]: Add tests unit for filterEntry (#1446) 2021-10-05 09:34:38 +05:30
Julien Fabre
f89f7d6e97
[GH-862] Add tests unit for newCardButton (#1424)
* chore[GH-#862]: add tests unit for newCardButton

* fix: views state

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-04 20:16:14 -06:00
Julien Fabre
9618d0079d
[GH-863] add tests unit for newCardButtonTemplateItem (#1414)
* chore[GH-#863]: add tests unit for newCardButtonTemplateItem

* chore: fix test view and add set as default test

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-04 19:48:10 -06:00
Chen-I Lim
58f6b8031a
Fix #1397. Add show empty toggle to Dashboard (#1398)
* Fix #1397. Add show empty toggle to Dashboard

* Update Jest snapshot

* Fix jest

* Use UserSettingKey
2021-10-04 14:27:30 -07:00
Asaad Mahmood
c332e455c1
Updating splash screen sizing for image and content (#1399)
* Updating splash screen sizing for image and content
2021-10-04 16:58:56 -04:00
Tiago Santos Da Silva
c24888977c
Typing adjustment - 1357 (#1411)
* fix: typing adjustment
2021-10-04 16:56:32 -04:00
Kolos Niedermayer
1af58f6e61
[GH-993] Fix csv export header (#1417)
* Fix csv header row
2021-10-04 16:53:10 -04:00
Fares Rihani
e931a6e56e
Webapp Linter Fixes - fix no-explicit-any warnings in options.tsx, workspaceOptions.tsx (#1427)
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-04 13:05:28 -06:00
Julien Fabre
c2f688e980
[GH-865] Add more tests unit to viewHeaderActionMenu (#1412)
* chore[#865]: add other test unit to viewHeaderActionMenu

* fix: add clearMocks

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-04 13:04:34 -06:00
Scott Bishel
0ac2fc0f62
gh-1360 Fix for tests using 'any' when wrapping components (#1374)
* fix for tests using any when wrapping components

* update/cleanup use of test wrappers

* fix up package

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-04 12:27:37 -06:00
Julien Fabre
7123311902
[GH-866] add unit test for viewHeaderGroupByMenu (#1403)
* --wip-- [skip ci]

* chore[#866]: add unit test for viewHeaderGroupByMenu

* fix: review test and add testUtils

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-04 12:01:54 -06:00
Julien Fabre
20933183b7
chore[GH-#861]: add unit test for filterValue" (#1428) 2021-10-04 13:08:00 -04:00
Miguel de la Cruz
711da0409f
Disable websockets in shared boards (#1391)
* Disable websockets in shared boards

* Address review comments

* Fix linter
2021-10-04 18:01:49 +02:00
kamre
c852ae2802
Views added to mocked store state. (#1434) 2021-10-04 08:04:36 -06:00
Fares Rihani
c34e3de24e
Webapp Linter Fixes - fix linter warnings for file markdownEditor.tsx (#1422) 2021-10-04 17:06:43 +05:30
Tiago Santos Da Silva
1d0bb180f4
Typing adjustment - 1354 (#1416)
* refactor: adjusting typing

* fix: Correction of some typings with unknown
2021-10-04 15:14:30 +05:30
Harshil Sharma
7ce9e44a5d
Resolved issue regarding openign boards link from channels (#1388)
* Resolved issue regarding openign boards link from channels

* Removed unnecessary check
2021-10-04 14:44:18 +05:30
Christopher Speller
ee721c89f1
Fix tiny icons caused by css pollution (#1327) 2021-10-04 10:06:19 +02:00
Hyia丶
ae8bf57160
Update default template (#516)
* Update default template

* Update default template display

* Add default template clear behavior

* Fix merged code

* remove important from css

* Update mutator

Co-authored-by: qingyang.zhong <qizhong@coupang.com>
2021-10-04 09:58:59 +02:00
kamre
1a747b780e
Fix displaying properties on kanban cards: (#1400)
- hide URL property only when it is empty
  - hide empty labels for Select/MultiSelect properties
2021-10-04 10:05:39 +05:30
Julien Fabre
edc89e04ce
[GH - 869] add unit test for viewHeaderSortMenu (#1402)
* chore[#869]: add unit test for viewHeaderSortMenu

* fix: name button in test...

* fix: review test and add testUtils
2021-10-04 09:59:04 +05:30
Julien Fabre
d0eefe8c85
[GH-867]: add unit tests for viewHeaderPropertiesMenu (#1404)
* chore[#867]: add test for viewHeaderPropertiesMenu

* fix: name test

* fix: snapshot on test viewHeaderPropertiesMenu

* fix: rollback cardDetailContents snap

* fix: comments from krame
2021-10-04 09:57:12 +05:30
Julien Fabre
cd261224c4
[GH-868]: add unit tests viewHeaderSearch (#1406)
* chore[#868]: add unit tests viewHeaderSearch

* fix: review test and add testUtils
2021-10-04 09:53:27 +05:30
Julien Fabre
b02708173a
[GH-864]: add tests unit for viewHeader (#1413)
* chore[GH-#864]: add test unit for viewHeader

* fix: eslint import useless
2021-10-04 09:52:30 +05:30
Scott Bishel
746d53c4f7
GH-Mobile banner css (#1326)
* mobile banner via css

* remove comment

* fix lint

* fix bad merge
2021-10-01 11:53:27 -06:00
Scott Bishel
35bb3e9024
add readtoken when in readonly mode (#1382) 2021-10-01 11:29:44 -06:00
xMicky24GIT
8a9bb92330
Fix kanban cards overlapping with header (#1234)
Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
2021-10-01 16:44:15 +05:30
Elisha Hollander
4264f69489
remove default return (#1384) 2021-10-01 16:02:18 +05:30
kamre
384e350c13
[GH-1111] Fix height for tooltip (#1123)
* Fix height for tooltip.

* Use unitless number for line-height.

Co-authored-by: Hossein <hahmadia@users.noreply.github.com>
2021-09-30 11:55:24 -07:00
kamre
7617d9e334
Fix dragging for gallery card: (#1303)
- use `translate3d` for proper preview in Chrome
  - set `pointer-events` to `none` to prevent image opening in Firefox

Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
2021-09-30 11:46:26 -07:00
Harshil Sharma
44520d5748
Allowed dashboard to scroll (#1377) 2021-09-30 07:48:30 -04:00
Scott Bishel
bde2a287e1
GH-1362: Fix missing return type on function (#1375)
* fix missing return type errors

* fix in userSettings
2021-09-29 17:58:36 -06:00
Scott Bishel
f92727f993
add additional telemetry tracking (#1220)
* add additional telemetry tracking

* add additional telemetry tracking

* update name of event

* update logging

* remove log lines
2021-09-29 16:37:20 -06:00
Miguel de la Cruz
ce98ec55fc
Recovers inactive websockets connections on reconnect in plugin mode (#1324)
* Stores a cache of inactive connections so their subscriptions are recovered on reconnections

* Adds test for getUserIDsForWorkspace and simplify messages through helpers

* Make the plugin websocket client more resilient

* Remove missed event callback and limit ws state polling to one at a time

* Add read lock for the plugin adapter and guarantee atomic ops on inactiveAt

* Add mutex to the plugin adapter client and tests to cover for races

* Split plugin adapter mutex in two and use them to lock only on data access

* Group plugin adapter fields by the mutex that's guarding them
2021-09-29 18:19:34 +02:00
CuriousCorrelation
7970d4e6c5
[GH-1082] Add count and percent table calculations for checkbox (#1323) 2021-09-29 12:08:11 +05:30
Harshil Sharma
e40424e319
Handled the case of missing user (#1367) 2021-09-29 11:27:21 +05:30
Hossein
7fae65ea02
Start Welcome Page (#1231)
* start welcome page

* setup template

* setup forwarding logic

* fix linting errors

* Updating UI

* Use intl strings

* Address comments

* go to baords welcome

* Fix image problem

* fix linting

* fix getting shown wrong things

* fix build issues

* fix cypress test and non plugin

* Fix bugs

* remove console

* Add welcome page

* address comments

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
2021-09-28 09:51:32 -04:00
Scott Bishel
cbfb4cb36f
GH-1312 - Update title when running a plugin (#1317)
* Update title when running a plugin

* Update webapp/src/pages/boardPage.tsx

Co-authored-by: Hossein <hahmadia@users.noreply.github.com>
2021-09-28 09:50:23 -04:00
Harshil Sharma
6c6351dae8
Made table calculations uneditable in readonly view (#1320)
* Made table calculations uneditable in readonly view

* Updated snapshots

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-09-28 15:29:06 +05:30
kamre
50470efe07
[GH-1057] Highlighting on hover for property values in the card dialog (#1065)
* Highlight property values on hover:
  - highlight on hover property values that are not readonly
  - make property name buttons the same width
  - set `min-width: 150px` for property values
  - add `readonly` class for LastModifiedAt/LastModifiedBy/CreatedAt

* Make `Editable` used in card property values automatically expandable:
  - input width computation relies on `useLayoutEffect` and `getComputedStyle`
  - enable automatic expand for editable fields in `PropertyValueElement`
  - enable automatic expand for editable inside `URLProperty`
  - fix for tooltip display in `KanbanCard`

* Fix issue with ellipsis in Chrome.

* Support highlight on hover for `UserProperty`

* Updating hover state and UI

* Jest snapshot updated.

* Fix jest snapshots

* Update jest snapshot

* Update jest snapshot

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Co-authored-by: Chen-I Lim <46905241+chenilim@users.noreply.github.com>
2021-09-24 17:56:21 -07:00
Chen-I Lim
3fbaf36009 Merge branch 'gh-1059-fix-empty-placeholder-in-card-dialog' of https://github.com/kamre/focalboard into kamre-gh-1059-fix-empty-placeholder-in-card-dialog 2021-09-24 16:47:07 -07:00