GH-1362: Fix missing return type on function (#1375)

* fix missing return type errors

* fix in userSettings

webapp/src/components/cardDialog.tsx

@@ -32,7 +32,7 @@ type Props = {
     readonly: boolean
 }
 
-const CardDialog = (props: Props) => {
+const CardDialog = (props: Props): JSX.Element => {
     const {board, activeView, cards, views} = props
     const card = useAppSelector(getCard(props.cardId))
     const contents = useAppSelector(getCardContents(props.cardId))

webapp/src/components/globalHeader/globalHeader.tsx

@@ -42,7 +42,7 @@ const HeaderItems = () => {
     )
 }
 
-const GlobalHeader = () => {
+const GlobalHeader = (): JSX.Element => {
     return (
         <ReduxProvider store={store}>
             <HeaderItems/>

webapp/src/components/table/tableRows.tsx

@@ -25,7 +25,7 @@ type Props = {
     onDrop: (srcCard: Card, dstCard: Card) => void
 }
 
-const TableRows = (props: Props) => {
+const TableRows = (props: Props): JSX.Element => {
     const {board, cards, activeView} = props
 
     const {offset, resizingColumn} = useDragLayer((monitor) => {

webapp/src/components/viewHeader/viewHeaderSearch.tsx

@@ -10,7 +10,7 @@ import Editable from '../../widgets/editable'
 import {useAppSelector, useAppDispatch} from '../../store/hooks'
 import {getSearchText, setSearchText} from '../../store/searchText'
 
-const ViewHeaderSearch = () => {
+const ViewHeaderSearch = (): JSX.Element => {
     const searchText = useAppSelector<string>(getSearchText)
     const dispatch = useAppDispatch()
     const intl = useIntl()

webapp/src/nativeApp.ts

@@ -9,7 +9,7 @@ declare interface INativeApp {
 
 declare const NativeApp: INativeApp
 
-export function importNativeAppSettings() {
+export function importNativeAppSettings(): void {
     if (typeof NativeApp === 'undefined' || !NativeApp.settingsBlob) {
         return
     }
@@ -19,7 +19,7 @@ export function importNativeAppSettings() {
     NativeApp.settingsBlob = null
 }
 
-export function notifySettingsChanged(key: string) {
+export function notifySettingsChanged(key: string): void {
     postWebKitMessage({type: 'didChangeUserSettings', settingsBlob: exportUserSettingsBlob(), key})
 }
 

webapp/src/octoClient.ts

@@ -81,7 +81,7 @@ class OctoClient {
         return false
     }
 
-    logout() {
+    logout(): void {
         localStorage.removeItem('focalboardSessionId')
     }
 

webapp/src/pages/boardPage.tsx

@@ -34,7 +34,7 @@ type Props = {
 
 const websocketTimeoutForBanner = 5000
 
-const BoardPage = (props: Props) => {
+const BoardPage = (props: Props): JSX.Element => {
     const intl = useIntl()
     const board = useAppSelector(getCurrentBoard)
     const activeView = useAppSelector(getCurrentView)

webapp/src/svg/dashboard-onboarding.tsx

@@ -3,7 +3,7 @@
 
 import React from 'react'
 
-export default function DashboardOnboardingSvg(props: React.HTMLAttributes<HTMLSpanElement>) {
+export default function DashboardOnboardingSvg(props: React.HTMLAttributes<HTMLSpanElement>): JSX.Element {
     return (
         <span {...props}>
             <svg

webapp/src/svg/search-illustration.tsx

@@ -3,7 +3,7 @@
 
 import React from 'react'
 
-export default function SearchIllustration(props: React.HTMLAttributes<HTMLSpanElement>) {
+export default function SearchIllustration(props: React.HTMLAttributes<HTMLSpanElement>): JSX.Element {
     return (
         <span {...props}>
             <svg

webapp/src/userSettings.ts

@@ -23,7 +23,7 @@ export class UserSettings {
         return localStorage.getItem(key)
     }
 
-    static set(key: UserSettingKey, value: string | null) {
+    static set(key: UserSettingKey, value: string | null): void {
         if (!Object.values(UserSettingKey).includes(key)) {
             return
         }
@@ -98,7 +98,7 @@ export class UserSettings {
         return json ? JSON.parse(json) : null
     }
 
-    static setEmojiMartSetting(key: string, value: any) {
+    static setEmojiMartSetting(key: string, value: any): void {
         const prefixed = `emoji-mart.${key}`
         Utils.assert((Object as any).values(UserSettingKey).includes(prefixed))
         UserSettings.set(prefixed as UserSettingKey, JSON.stringify(value))