Commit graph

253 commits

Author SHA1 Message Date
Harshil Sharma
2ac56dbfba
Ported view limits to main (#3252)
* Ported view limits to main

* lint fix

* Added tests

* Added tests

* Fixed a server test

* fixed webapp test

* fixed webapp test

* fixing some tests

* implement check when duplicating views

* Fixed webapp tests

* Fixed webapp tests

* Fixed webapp tests

* Trying without race test

* Lets race again

* Made error descriptive

* Minor improvements

* Updates snapshots for changed alt text

* Updates snapshots for changed alt text

Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
2022-06-29 18:05:24 +05:30
Rajat Dabade
853c2950f5
Cherry pick to main for add board link in bot notification (#3272)
Co-authored-by: Varghese Jose <varghese.jose@tutanota.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: jprusch <rs@schaeferbarthold.de>
2022-06-24 12:39:04 +05:30
Scott Bishel
2f0c1235bb
don't copy 'comment' blocks (#3267)
* don't copy 'comment' blocks

* update tests

* lint fixes
2022-06-22 15:57:27 -06:00
Doug Lauder
39c1d07974
Update 000017_add_file_info.up.sql (#3266)
Make CREATE TABLE idempotent.
2022-06-22 12:51:06 -04:00
Scott Bishel
34e7f88f53
add cyclo complexity, update migrate() to use defer (#3257) 2022-06-21 09:12:55 -06:00
Harshil Sharma
ed79026578
Fix failure to upgrade from 7.0 to 7.2 (#3240)
* WIP

* Removed placeholder migrationa s no longer needed

* Removed placeholder migrationa s no longer needed
2022-06-16 12:55:48 +02:00
Miguel de la Cruz
fa6de94070
Adds limits implementation to the server (#3213)
* Adds limits implementation to the server

* Add test for deleted boards on active card count
2022-06-15 12:17:44 +02:00
Harshil Sharma
f3faf39eaa
Forward-porting fileinfo limits (#3164)
* Updated go version

* Generated mocks

* lint fix

* lint fix

* lint fix

* backported fileinfo limits

* backported fileinfo limits

* added tests

* synced with main

* Server lint fix

* used a better name
2022-06-13 13:35:42 +05:30
Doug Lauder
95d0f37420
Migration fixes (#3196)
* simplify block.board_id population
* only create tables if not existing
* fix migration ordering
* fix min schema versions for code-based migrations
2022-06-08 10:13:56 -04:00
Harshil Sharma
2ab4e95289
Updated go version (#3189)
* Updated go version

* Generated mocks

* lint fix

* lint fix

* lint fix

* Updated gitlab builder image
2022-06-06 10:18:21 +02:00
Doug Lauder
fa258fe91e
fix postgres SQL for legacyBoardFields (#3111)
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-05-26 18:11:53 -04:00
Harshil Sharma
d6e494ca29
Fixed a bug where migrations didn't run on a clean DB (#3104) 2022-05-24 09:40:34 +02:00
Jesús Espino
d3edf2f698
Adding the board default role for public boards (#2884)
* Adding the default role concept in the backend

* Adding the interface part

* Fix golang-ci lint errors

* Adding local permissions tests

* Address PR review comments

* Improving the code a bit

* Another small fix

* Renaming DefaultRole to MinimumRole

* Setting the minimum role at minimum to check the permissions per roles in the integration tests

* Adding the new minimum role behavior

* Fixing some tests

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-05-16 10:09:11 -06:00
Doug Lauder
11bd3720f1
Refactor notify init (#3043)
* remove unneeded store interfaces

* - reduce dependencies for notifications service
- notifications service no longer concerned with web socket notifications

gnored, and an empty message aborts the commit.

* use app to add member to board

* remove unneeded API

* remove dependency on app package

* fix webapp jest

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-05-16 11:53:41 -04:00
Doug Lauder
554a790e57
standardize env var naming (#3031) 2022-05-05 15:49:34 -04:00
Doug Lauder
1ff28087f8
GH-2469 Add board-bot to team (#3026)
* add bot to team before any mention or subscription notification
2022-05-04 16:10:26 -04:00
Scott Bishel
24ff8d5d38
update board title when duplicated (#3011) 2022-05-03 12:44:34 -06:00
Miguel de la Cruz
c08ce96076
Remove timeout from MySQL migrations (#2974) 2022-04-28 11:58:17 -06:00
Miguel de la Cruz
ae97d5c314
Move teamless data migration with the rest of data migrations and update teamless boards query (#2942)
* Move teamless data migration with the rest of data migrations

* Fix get board user teams query to work on both Postgres and MySQL
2022-04-27 13:34:02 -06:00
Miguel de la Cruz
dc07df6bc9
Update permissions migration to ensure all boards are either open or private (#2928) 2022-04-27 18:21:26 +02:00
Miguel de la Cruz
74e39fa5bf
Initialise the store with a single user flag and pass it to the migrations (#2906) 2022-04-27 15:11:27 +02:00
Scott Bishel
5efcc4dcac
Implement Boards Data Retention - Take 2 (#2859)
* implement boards data retention

* cleanup logs

* revert removal

* update logger creation
2022-04-25 12:58:08 -06:00
Miguel de la Cruz
a439d11f66
Handle jsonb fields on postgres with binary_parameters set (#2854)
* Handle jsonb fields on postgres with binary_parameters set

* Finx linter adding dot
2022-04-25 17:43:06 +02:00
Doug Lauder
cabc15b226
reduce log level when deliverying notifications to users without permission (#2912) 2022-04-22 11:32:15 -06:00
Harshil Sharma
c64b95cf92
Updated update category-board mapping method to not rely on DB returning affected rows (#2840)
* Updated update category-board mapping method to not rely on DB returning affected rows

* Wrapped into transaction
2022-04-20 09:21:53 -06:00
Doug Lauder
936cc820ab
Standardize err not found (#2834)
* cleanup log levels

* Standardize on model.IsErrNotFound instead of the mix of error checking done previously.

* fix merge conflicts

* fix comment typo

* add description to asserts
2022-04-20 11:02:12 -04:00
Harshil Sharma
183c8157cb
Removed teamID from search API (#2842) 2022-04-19 17:43:40 -06:00
Scott Bishel
74053655b6
Revert "implement data retention for boards (#2588)" (#2843)
This reverts commit 0489de8bd3.
2022-04-19 09:18:31 -06:00
Harshil Sharma
50930a1cd3
Cross team search (#2829)
* WIP

* Added test

* Added snapshot

* Updated server tests

* Fixed server lint

* Fixed webapp lint

* Updated server tests
2022-04-19 10:27:14 +05:30
Scott Bishel
0489de8bd3
implement data retention for boards (#2588)
* implement data retention for boards

* fix lint errors

* start of orphans

* add and update tests

* fixes for merge

* fix tests

* fix lint

* reset from testing

* update setting unit test variable

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-04-18 09:03:42 -06:00
Doug Lauder
b47e70579b
cleanup log levels (#2824) 2022-04-18 08:21:44 -04:00
Scott Bishel
a2e7deba84
make all duplicated boards private (#2823) 2022-04-15 14:29:33 -06:00
Scott Bishel
5723709605
make board private when created from template (#2821) 2022-04-15 11:27:21 -06:00
Scott Bishel
90677ba7b8
GH 2393 Move calculationColumns from board to view (#2762)
* move calculation columns to view

* update tests

* add conversion for column calculations

* remove column_Calculations from boards and boards_history

* updates from testing

* update for sqlite

* fixes from testing

* fix lint, cleanup

* update templates,remove field from boards

* revert bad changes

* update snapshots

* Update server/services/store/sqlstore/migrations/000017_add_teams_and_boards.up.sql

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-04-14 10:33:57 -06:00
Chen-I Lim
5b423d6647
CI updates: Speed up register / login, minimize Windows tests, and add Mac tests (#2784)
* Upgrade npm in build-ubuntu

* npm i -S moment

* Don't upgrade npm

* macos-latest on build-mac

* Update dev-release.yml

* Add CI for macOS

* Lower password hash during unit tests

* Add comment

* Only integration tests on Windows

* Tweak TestCreateRecurringTask timings

* Fix server-test-mini-sqlite
2022-04-13 15:36:20 -07:00
Jesús Espino
bc37e97ae9
Applying migration changes (#2752)
* Applying migration changes

* Fixing linter erros

* Restoring userID

* Updated user id length

* Update server/app/category_boards.go

* Skiped creating categories for boards belonging to DMs

* Handled private group messages as well

* fix sql error for insert_at

* fix timestamp parsing

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
2022-04-13 16:10:53 -06:00
Doug Lauder
89cc947a21
Implement permissions specs for mentions. (#2758)
* Implement permissions specs for mentions.
- public boards: admin, editor, commenter can mention team members and auto-add them to board; guests can mention board members
- private boards:  admin, editor, commenter, guest can mention board members
- viewers cannot mention
2022-04-13 18:09:55 -04:00
Chen-I Lim
8433b9eada
Fix CI: Data tamper attempt (#2782)
* Upgrade npm in build-ubuntu

* npm i -S moment

* Don't upgrade npm

* macos-latest on build-mac

* Update dev-release.yml

* Expected update time is right after insert returns
2022-04-13 12:17:30 -07:00
Harshil Sharma
15cac1b066 Avoided using UUID() as function param for MySQL migration 2022-04-13 12:12:50 +05:30
Spiros Economakis
539aee6a46
Fix configuration for prometheus address (#2763)
The env variable for prometheus address is not respected as it should be set as
viper default config.

Ticket: https://mattermost.atlassian.net/browse/43295
2022-04-12 17:43:29 -04:00
Chen-I Lim
af35a8e2c2
GH 2593: Fix Windows migration (#2767)
* Upgrade npm in build-ubuntu

* npm i -S moment

* Don't upgrade npm

* macos-latest on build-mac

* Update dev-release.yml

* Fix #2593: Fix Windows migration
2022-04-12 12:17:58 -07:00
Miguel de la Cruz
c5f8b7f142
Add coalesce to template version migration (#2764) 2022-04-12 08:47:45 -04:00
Jesús Espino
f3267e2458
Fixing delete/undelete boards (#2571)
* Fixing delete/undelete boards

* Adding permissions checks for undelete board and undelete block

* Fixing server-lint

* Handling permissions for deleted boards

* Fixing linter errors

* Fixing tests

* Update server/services/store/sqlstore/board.go

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

* Fixing error message

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
2022-04-08 13:31:28 -04:00
Doug Lauder
30e6bc477d
GH-2745 Don't init default templates when unit testing (#2748)
* Don't warn when  appears in card followed by text that is not a username

* Selectively initalize default templates for unit tests that need them to reduce test times. Reduce log noise.
2022-04-08 13:46:16 +02:00
Doug Lauder
68b623ff29
Don't warn when appears in card followed by text that is not a username (#2747) 2022-04-07 17:39:35 -04:00
Doug Lauder
ff020d85e3
Don't notify non-board members of card changes (#2718)
* Don't notify non-board members of card changes
- include permissions service in notifications backends
- use permissions service to ensure @mentions are to users on team
- use permissions service to ensure subscribers are members of board
2022-04-07 11:42:32 -04:00
Jesús Espino
0363357209
Simplifying the categories migration (#2739)
* Simplifying the categories migration

* A bit more of simplification

* Leaving the channel_id there because sqlite doesn't support drop columns

* Update server/services/store/sqlstore/migrations/000018_populate_categories.up.sql

* Update server/services/store/sqlstore/migrations/000019_populate_category_blocks.up.sql

* Update server/services/store/sqlstore/migrations/000018_populate_categories.up.sql

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
2022-04-06 16:15:50 -04:00
Jesús Espino
6fef5f0c92
Avoid possible problem of block history with null in the title (#2721)
* Avoid possible problem of block history with null in the title

* Making title not nullable
2022-04-06 18:55:03 +02:00
Scott Bishel
dc72e3d3bd
Merge pull request #2664 from jespino/issue-2617
Adding file size limit
2022-04-06 10:43:41 -06:00
Jesús Espino
c3cb4a1491 Fixing tests 2022-04-06 16:04:21 +02:00