luisgulo/focalboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Avoid possible problem of block history with null in the title (#2721)

Browse source 
* Avoid possible problem of block history with null in the title

* Making title not nullable
This commit is contained in:
Jesús Espino 2022-04-06 18:55:03 +02:00 committed by GitHub
parent dc72e3d3bd
commit 6fef5f0c92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
server/services/store/sqlstore/migrations/000017_add_teams_and_boards.up.sql
View file

@ -36,7 +36,7 @@ CREATE TABLE {{.prefix}}boards (
created_by VARCHAR(36),
modified_by VARCHAR(36),
type VARCHAR(1) NOT NULL,
title TEXT,
title TEXT NOT NULL,
description TEXT,
icon VARCHAR(256),
show_description BOOLEAN,
@ -74,7 +74,7 @@ CREATE TABLE {{.prefix}}boards_history (
created_by VARCHAR(36),
modified_by VARCHAR(36),
type VARCHAR(1) NOT NULL,
title TEXT,
title TEXT NOT NULL,
description TEXT,
icon VARCHAR(256),
show_description BOOLEAN,
@ -107,7 +107,9 @@ CREATE TABLE {{.prefix}}boards_history (
{{if .plugin}}
{{if .postgres}}
INSERT INTO {{.prefix}}boards (
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.type, B.title, (B.fields->>'description')::text,
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.type,
COALESCE(B.title, ''),
(B.fields->>'description')::text,
B.fields->>'icon',
COALESCE((fields->'showDescription')::text::boolean, false),
COALESCE((fields->'isTemplate')::text::boolean, false),
@ -119,7 +121,9 @@ CREATE TABLE {{.prefix}}boards_history (
WHERE B.type='board'
);
INSERT INTO {{.prefix}}boards_history (
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.type, B.title, (B.fields->>'description')::text,
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.type,
COALESCE(B.title, ''),
(B.fields->>'description')::text,
B.fields->>'icon',
COALESCE((fields->'showDescription')::text::boolean, false),
COALESCE((fields->'isTemplate')::text::boolean, false),
@ -133,7 +137,9 @@ CREATE TABLE {{.prefix}}boards_history (
{{end}}
{{if .mysql}}
INSERT INTO {{.prefix}}boards (
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.Type, B.title, JSON_UNQUOTE(JSON_EXTRACT(B.fields,'$.description')),
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.Type,
COALESCE(B.title, ''),
JSON_UNQUOTE(JSON_EXTRACT(B.fields,'$.description')),
JSON_UNQUOTE(JSON_EXTRACT(B.fields,'$.icon')),
COALESCE(B.fields->'$.showDescription', 'false') = 'true',
COALESCE(JSON_EXTRACT(B.fields, '$.isTemplate'), 'false') = 'true',
@ -145,7 +151,9 @@ CREATE TABLE {{.prefix}}boards_history (
WHERE B.type='board'
);
INSERT INTO {{.prefix}}boards_history (
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.Type, B.title, JSON_UNQUOTE(JSON_EXTRACT(B.fields,'$.description')),
SELECT B.id, B.insert_at, C.TeamId, B.channel_id, B.created_by, B.modified_by, C.Type,
COALESCE(B.title, ''),
JSON_UNQUOTE(JSON_EXTRACT(B.fields,'$.description')),
JSON_UNQUOTE(JSON_EXTRACT(B.fields,'$.icon')),
COALESCE(B.fields->'$.showDescription', 'false') = 'true',
COALESCE(JSON_EXTRACT(B.fields, '$.isTemplate'), 'false') = 'true',
@ -160,7 +168,9 @@ CREATE TABLE {{.prefix}}boards_history (
{{else}}
{{if .postgres}}
INSERT INTO {{.prefix}}boards (
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O', title, (fields->>'description')::text,
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O',
COALESCE(B.title, ''),
(fields->>'description')::text,
B.fields->>'icon',
COALESCE((fields->'showDescription')::text::boolean, false),
COALESCE((fields->'isTemplate')::text::boolean, false),
@ -171,7 +181,9 @@ CREATE TABLE {{.prefix}}boards_history (
WHERE type='board'
);
INSERT INTO {{.prefix}}boards_history (
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O', title, (fields->>'description')::text,
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O',
COALESCE(B.title, ''),
(fields->>'description')::text,
B.fields->>'icon',
COALESCE((fields->'showDescription')::text::boolean, false),
COALESCE((fields->'isTemplate')::text::boolean, false),
@ -184,7 +196,9 @@ CREATE TABLE {{.prefix}}boards_history (
{{end}}
{{if .mysql}}
INSERT INTO {{.prefix}}boards (
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O', title, JSON_UNQUOTE(JSON_EXTRACT(fields,'$.description')),
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O',
COALESCE(B.title, ''),
JSON_UNQUOTE(JSON_EXTRACT(fields,'$.description')),
JSON_UNQUOTE(JSON_EXTRACT(fields,'$.icon')),
COALESCE(B.fields->'$.showDescription', 'false') = 'true',
COALESCE(JSON_EXTRACT(B.fields, '$.isTemplate'), 'false') = 'true',
@ -195,7 +209,9 @@ CREATE TABLE {{.prefix}}boards_history (
WHERE type='board'
);
INSERT INTO {{.prefix}}boards_history (
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O', title, JSON_UNQUOTE(JSON_EXTRACT(fields,'$.description')),
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O',
COALESCE(B.title, ''),
JSON_UNQUOTE(JSON_EXTRACT(fields,'$.description')),
JSON_UNQUOTE(JSON_EXTRACT(fields,'$.icon')),
COALESCE(B.fields->'$.showDescription', 'false') = 'true',
COALESCE(JSON_EXTRACT(B.fields, '$.isTemplate'), 'false') = 'true',
@ -208,7 +224,9 @@ CREATE TABLE {{.prefix}}boards_history (
{{end}}
{{if .sqlite}}
INSERT INTO {{.prefix}}boards
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O', title, json_extract(fields, '$.description'),
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O',
COALESCE(title, ''),
json_extract(fields, '$.description'),
json_extract(fields, '$.icon'), json_extract(fields, '$.showDescription'), json_extract(fields, '$.isTemplate'),
json_extract(fields, '$.templateVer'),
'{}', json_extract(fields, '$.cardProperties'), json_extract(fields, '$.columnCalculations'), create_at,
@ -217,7 +235,9 @@ CREATE TABLE {{.prefix}}boards_history (
WHERE type='board'
;
INSERT INTO {{.prefix}}boards_history
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O', title, json_extract(fields, '$.description'),
SELECT id, insert_at, '0', channel_id, created_by, modified_by, 'O',
COALESCE(title, ''),
json_extract(fields, '$.description'),
json_extract(fields, '$.icon'), json_extract(fields, '$.showDescription'), json_extract(fields, '$.isTemplate'),
json_extract(fields, '$.templateVer'),
'{}', json_extract(fields, '$.cardProperties'), json_extract(fields, '$.columnCalculations'), create_at,