From 84cdf61730fcd8e9905d99d96324961462a1fec2 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Tue, 5 Aug 2014 18:49:22 +0900 Subject: [PATCH] Do not require reloading of .vimrc after PlugUpgrade --- README.md | 16 ++++++++-------- plug.vim | 34 ++++++++++++++++++++++------------ 2 files changed, 30 insertions(+), 20 deletions(-) diff --git a/README.md b/README.md index 8a77d31..37806f1 100644 --- a/README.md +++ b/README.md @@ -61,14 +61,14 @@ Reload .vimrc and `:PlugInstall` to install plugins. ### Commands -| Command | Description | -| ----------------------------------- | ----------------------------------------------------------------------- | -| `PlugInstall [name ...] [#threads]` | Install plugins | -| `PlugUpdate [name ...] [#threads]` | Install or update plugins | -| `PlugClean[!]` | Remove unused directories (bang version will clean without prompt) | -| `PlugUpgrade` | Upgrade vim-plug itself. You may need to reload `.vimrc` after upgrade. | -| `PlugStatus` | Check the status of plugins | -| `PlugDiff` | See the updated changes from the previous PlugUpdate | +| Command | Description | +| ----------------------------------- | ------------------------------------------------------------------ | +| `PlugInstall [name ...] [#threads]` | Install plugins | +| `PlugUpdate [name ...] [#threads]` | Install or update plugins | +| `PlugClean[!]` | Remove unused directories (bang version will clean without prompt) | +| `PlugUpgrade` | Upgrade vim-plug itself | +| `PlugStatus` | Check the status of plugins | +| `PlugDiff` | See the updated changes from the previous PlugUpdate | ### `Plug` options diff --git a/plug.vim b/plug.vim index 3e344c3..3e56bd0 100644 --- a/plug.vim +++ b/plug.vim @@ -101,15 +101,18 @@ function! plug#begin(...) " we want to keep track of the order plugins where registered. let g:plugs_order = [] + call s:define_commands() + return 1 +endfunction + +function! s:define_commands() command! -nargs=+ -bar Plug call s:add() command! -nargs=* -bar -bang -complete=customlist,s:names PlugInstall call s:install('' == '!', ) command! -nargs=* -bar -bang -complete=customlist,s:names PlugUpdate call s:update('' == '!', ) command! -nargs=0 -bar -bang PlugClean call s:clean('' == '!') - command! -nargs=0 -bar PlugUpgrade if s:upgrade() | execute 'source '. s:me | call s:upgrade_specs() | endif + command! -nargs=0 -bar PlugUpgrade if s:upgrade() | execute 'source '. s:me | endif command! -nargs=0 -bar PlugStatus call s:status() command! -nargs=0 -bar PlugDiff call s:diff() - - return 1 endfunction function! s:to_a(v) @@ -1003,16 +1006,13 @@ function! s:upgrade() call system(printf( \ 'curl -fLo %s %s && '.cp.' %s %s.old && '.mv.' %s %s', \ new, s:plug_source, mee, mee, new, mee)) - if v:shell_error == 0 - unlet g:loaded_plug - echo 'Downloaded '. s:plug_source - return 1 - else + if v:shell_error return s:err('Error upgrading vim-plug') endif elseif has('ruby') echo 'Downloading '. s:plug_source - ruby << EOF + try + ruby << EOF require 'open-uri' require 'fileutils' me = VIM::evaluate('s:me') @@ -1024,12 +1024,16 @@ function! s:upgrade() FileUtils.cp me, old File.rename new, me EOF - unlet g:loaded_plug - echo 'Downloaded '. s:plug_source - return 1 + catch + return s:err('Error upgrading vim-plug') + endtry else return s:err('curl executable or ruby support not found') endif + + unlet g:loaded_plug + echo 'Downloaded '. s:plug_source + return 1 endfunction function! s:upgrade_specs() @@ -1146,6 +1150,12 @@ endfunction let s:first_rtp = s:esc(get(split(&rtp, ','), 0, '')) let s:last_rtp = s:esc(get(split(&rtp, ','), -1, '')) +if exists('g:plugs') + let g:plugs_order = get(g:, 'plugs_order', keys(g:plugs)) + call s:upgrade_specs() + call s:define_commands() +endif + let &cpo = s:cpo_save unlet s:cpo_save