From d1b3110f844e39f5e21c29fe69dbffa5948c4cdd Mon Sep 17 00:00:00 2001 From: Christophe Grenier Date: Fri, 2 Jul 2021 18:16:24 +0200 Subject: [PATCH] src/file_mfg.c: improve Frama-C annotations --- src/file_mfg.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/file_mfg.c b/src/file_mfg.c index 51c70492..fb81c0fa 100644 --- a/src/file_mfg.c +++ b/src/file_mfg.c @@ -31,7 +31,7 @@ #include "types.h" #include "filegen.h" -/*@ requires \valid(file_stat); */ +/*@ requires valid_register_header_check(file_stat); */ static void register_header_check_mfg(file_stat_t *file_stat); const file_hint_t file_hint_mfg= { @@ -44,16 +44,12 @@ const file_hint_t file_hint_mfg= { }; /*@ - @ requires valid_file_recovery(file_recovery); - @ requires \valid(file_recovery->handle); - @ requires \separated(file_recovery, file_recovery->handle, file_recovery->extension, &errno, &Frama_C_entropy_source); - @ requires \initialized(&file_recovery->time); - @ @ requires file_recovery->file_check == &file_check_mfg; + @ requires valid_file_check_param(file_recovery); + @ ensures valid_file_check_result(file_recovery); @ assigns *file_recovery->handle, errno, file_recovery->file_size; @ assigns Frama_C_entropy_source; @ - @ ensures \valid(file_recovery->handle); @*/ static void file_check_mfg(file_recovery_t *file_recovery) { @@ -64,15 +60,10 @@ static void file_check_mfg(file_recovery_t *file_recovery) } /*@ - @ requires buffer_size > 0; - @ requires \valid_read(buffer+(0..buffer_size-1)); - @ requires valid_file_recovery(file_recovery); - @ requires \valid(file_recovery_new); - @ requires file_recovery_new->blocksize > 0; @ requires separation: \separated(&file_hint_mfg, buffer+(..), file_recovery, file_recovery_new); + @ requires valid_header_check_param(buffer, buffer_size, safe_header_only, file_recovery, file_recovery_new); + @ ensures valid_header_check_result(\result, file_recovery_new); @ assigns *file_recovery_new; - @ ensures \result == 0 || \result == 1; - @ ensures \result!=0 ==> valid_file_recovery(file_recovery_new); @*/ static int header_check_mfg(const unsigned char *buffer, const unsigned int buffer_size, const unsigned int safe_header_only, const file_recovery_t *file_recovery, file_recovery_t *file_recovery_new) {