luisgulo/reactpy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update parameter name in starlette.py (#1031)

Browse source 
Looks like the configure() method has an error in the component parameter.

In the code documentation, the parameter indicates 'component' but the name is 'constructor', I've reviewed other files, and looks like the standard is 'component'.
This commit is contained in:
Juan José Cano Duque 2023-06-10 13:09:44 -05:00 committed by GitHub
parent 2962ed97f7
commit b1a251684d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/py/reactpy/reactpy/backend/starlette.py
View file

@ -36,7 +36,7 @@ logger = logging.getLogger(__name__)
def configure(
app: Starlette,
constructor: RootComponentConstructor,
component: RootComponentConstructor,
options: Options | None = None,
) -> None:
"""Configure the necessary ReactPy routes on the given app.
@ -49,7 +49,7 @@ def configure(
options = options or Options()
# this route should take priority so set up it up first
_setup_single_view_dispatcher_route(options, app, constructor)
_setup_single_view_dispatcher_route(options, app, component)
_setup_common_routes(options, app)
@ -129,7 +129,7 @@ def _make_index_route(options: Options) -> Callable[[Request], Awaitable[HTMLRes
def _setup_single_view_dispatcher_route(
options: Options, app: Starlette, constructor: RootComponentConstructor
options: Options, app: Starlette, component: RootComponentConstructor
) -> None:
@app.websocket_route(str(STREAM_PATH))
@app.websocket_route(f"{STREAM_PATH}/{{path:path}}")
@ -145,7 +145,7 @@ def _setup_single_view_dispatcher_route(
await serve_layout(
Layout(
ConnectionContext(
constructor(),
component(),
value=Connection(
scope=socket.scope,
location=Location(pathname, f"?{search}" if search else ""),