From 6e53a88708570a4f15a570649568917a7bcf887e Mon Sep 17 00:00:00 2001 From: Theresa Gresch Date: Tue, 17 Dec 2019 17:02:56 +0100 Subject: [PATCH 1/6] Add test for keywords.go --- internal/util/keywords_test.go | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 internal/util/keywords_test.go diff --git a/internal/util/keywords_test.go b/internal/util/keywords_test.go new file mode 100644 index 000000000..c99af5e12 --- /dev/null +++ b/internal/util/keywords_test.go @@ -0,0 +1,18 @@ +package util + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestKeywords(t *testing.T) { + t.Run("cat", func(t *testing.T) { + keywords := Keywords("cat") + assert.Equal(t, []string{"cat"}, keywords) + }) + t.Run("was", func(t *testing.T) { + keywords := Keywords("was") + assert.Equal(t, []string(nil), keywords) + }) +} From 1f40f7eab7951c662f7954a2f1b9c5da18b47d10 Mon Sep 17 00:00:00 2001 From: Theresa Gresch Date: Tue, 17 Dec 2019 17:03:14 +0100 Subject: [PATCH 2/6] Add test for mime.go --- internal/util/mime_test.go | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 internal/util/mime_test.go diff --git a/internal/util/mime_test.go b/internal/util/mime_test.go new file mode 100644 index 000000000..2ee12d3a7 --- /dev/null +++ b/internal/util/mime_test.go @@ -0,0 +1,20 @@ +package util + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestMimeType(t *testing.T) { + t.Run("jpg", func(t *testing.T) { + filename := ExpandedFilename("./testdata/test.jpg") + mimeType := MimeType(filename) + assert.Equal(t, "image/jpeg", mimeType) + }) + t.Run("not existing filename", func(t *testing.T) { + filename := ExpandedFilename("./testdata/xxx.jpg") + mimeType := MimeType(filename) + assert.Equal(t, "", mimeType) + }) +} From dffd61037abcbba711c977971f4754a357e8e3b5 Mon Sep 17 00:00:00 2001 From: Theresa Gresch Date: Tue, 17 Dec 2019 17:03:36 +0100 Subject: [PATCH 3/6] Add test for token.go --- internal/util/token_test.go | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 internal/util/token_test.go diff --git a/internal/util/token_test.go b/internal/util/token_test.go new file mode 100644 index 000000000..296f23ca6 --- /dev/null +++ b/internal/util/token_test.go @@ -0,0 +1,29 @@ +package util + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestRandomToken(t *testing.T) { + t.Run("size 4", func(t *testing.T) { + token := RandomToken(4) + assert.NotEmpty(t, token) + }) + t.Run("size 8", func(t *testing.T) { + token := RandomToken(9) + assert.NotEmpty(t, token) + }) +} + +func TestUUID(t *testing.T) { + t.Run("size 4", func(t *testing.T) { + uuid := UUID() + assert.Equal(t, 36, len(uuid)) + }) + t.Run("size 8", func(t *testing.T) { + uuid := UUID() + assert.Equal(t, 36, len(uuid)) + }) +} From 4c5219c4f4d9d67699a88a419cf930838b2b998b Mon Sep 17 00:00:00 2001 From: Theresa Gresch Date: Tue, 17 Dec 2019 17:03:56 +0100 Subject: [PATCH 4/6] Add test for strings.go --- internal/util/strings_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/internal/util/strings_test.go b/internal/util/strings_test.go index 87f49d784..09e268acf 100644 --- a/internal/util/strings_test.go +++ b/internal/util/strings_test.go @@ -6,6 +6,15 @@ import ( "github.com/stretchr/testify/assert" ) +func TestContainsNumber(t *testing.T) { + t.Run("True", func(t *testing.T) { + assert.Equal(t, true, ContainsNumber("f3abcde")) + }) + t.Run("False", func(t *testing.T) { + assert.Equal(t, false, ContainsNumber("abcd")) + }) +} + func TestIsSeparator(t *testing.T) { t.Run("rune A", func(t *testing.T) { assert.Equal(t, false, isSeparator('A')) From 82a02e5032afd037b7735b48963be306244c1587 Mon Sep 17 00:00:00 2001 From: Michael Mayer Date: Tue, 17 Dec 2019 17:11:31 +0100 Subject: [PATCH 5/6] Places: Don't query for small position changes Signed-off-by: Michael Mayer --- frontend/src/pages/places.vue | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/frontend/src/pages/places.vue b/frontend/src/pages/places.vue index 009cdc950..89448cd3e 100644 --- a/frontend/src/pages/places.vue +++ b/frontend/src/pages/places.vue @@ -2,8 +2,7 @@ + @update:center="onCenter">