f74eea11ba
* fix for handling feature flags changing * update tests * fix tests * lint fixes * feedback updates * use getConfig instead * linter fix * more linter * revert changes Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
95 lines
2.3 KiB
Go
95 lines
2.3 KiB
Go
package main
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/mattermost/focalboard/server/model"
|
|
"github.com/mattermost/focalboard/server/server"
|
|
"github.com/mattermost/focalboard/server/services/config"
|
|
"github.com/mattermost/focalboard/server/ws"
|
|
serverModel "github.com/mattermost/mattermost-server/v6/model"
|
|
"github.com/mattermost/mattermost-server/v6/plugin/plugintest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type TestHelper struct {
|
|
Server *server.Server
|
|
}
|
|
|
|
func SetupTestHelper() *TestHelper {
|
|
th := &TestHelper{}
|
|
th.Server = newTestServer()
|
|
return th
|
|
}
|
|
|
|
func newTestServer() *server.Server {
|
|
srv, err := server.New(server.Params{
|
|
Cfg: &config.Configuration{},
|
|
})
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
return srv
|
|
}
|
|
|
|
func TestConfigurationNullConfiguration(t *testing.T) {
|
|
plugin := &Plugin{}
|
|
assert.NotNil(t, plugin.getConfiguration())
|
|
}
|
|
|
|
func TestOnConfigurationChange(t *testing.T) {
|
|
stringRef := ""
|
|
|
|
basePlugins := make(map[string]map[string]interface{})
|
|
basePlugins[pluginName] = make(map[string]interface{})
|
|
basePlugins[pluginName][sharedBoardsName] = true
|
|
|
|
baseFeatureFlags := &serverModel.FeatureFlags{
|
|
BoardsFeatureFlags: "Feature1-Feature2",
|
|
}
|
|
basePluginSettings := &serverModel.PluginSettings{
|
|
Directory: &stringRef,
|
|
Plugins: basePlugins,
|
|
}
|
|
|
|
baseConfig := &serverModel.Config{
|
|
FeatureFlags: baseFeatureFlags,
|
|
PluginSettings: *basePluginSettings,
|
|
}
|
|
|
|
t.Run("Test Load Plugin Success", func(t *testing.T) {
|
|
th := SetupTestHelper()
|
|
api := &plugintest.API{}
|
|
api.On("GetUnsanitizedConfig").Return(baseConfig)
|
|
|
|
p := Plugin{}
|
|
p.SetAPI(api)
|
|
p.server = th.Server
|
|
p.wsPluginAdapter = &FakePluginAdapter{}
|
|
|
|
err := p.OnConfigurationChange()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, count)
|
|
|
|
// make sure both App and Server got updated
|
|
assert.True(t, p.server.Config().EnablePublicSharedBoards)
|
|
assert.True(t, p.server.App().GetClientConfig().EnablePublicSharedBoards)
|
|
|
|
assert.Equal(t, "true", p.server.Config().FeatureFlags["Feature1"])
|
|
assert.Equal(t, "true", p.server.Config().FeatureFlags["Feature2"])
|
|
assert.Equal(t, "", p.server.Config().FeatureFlags["Feature3"])
|
|
})
|
|
}
|
|
|
|
var count = 0
|
|
|
|
type FakePluginAdapter struct {
|
|
ws.PluginAdapter
|
|
}
|
|
|
|
func (c *FakePluginAdapter) BroadcastConfigChange(clientConfig model.ClientConfig) {
|
|
count++
|
|
}
|