Commit graph

28 commits

Author SHA1 Message Date
Jesús Espino
393b961a6b
Refactor of prorperties (#3356)
* Initial commit for refactoring properties

* More work on isolating properties

* Some other fixes in tests!

* Handle gracefully the unknown properties

* Moving properties outside components folder

* Finishing changes to move the properties out of components

* Moving more things to the property logic

* Some improvements on properties

* Cleaner class based approach for property types

* Removing accidentally added people prop

* A bit of simplification

* Fixing some tests

* Fixing more tests

* Fixing more tests

* All tests working

* Fixing eslint errors

* Adding the filtering logic for text and boolean properties

* Adding support for searching by title

* Fixing some tests and adding others

* Fixing tests

* Removing TODO

* Addressing PR review comments

* Fixing filterValue test after merge

* Removing accidentailly included typo

* Fixing typo introduced
2022-08-16 18:00:43 +02:00
Scott Bishel
a129dbc1b8
Store current input while user is changing. (#3256)
* add ref to retrieve current text setting

* change to handle without forwardRefs

* state not needed here

* cleanup

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-07-27 21:35:36 +02:00
Scott Bishel
b911de0cc3
CP - Update en.json: Bug fix and consistency (#3231)
* Update en.json: Bug fix and consistency (#3151)

* Update en.json

Updated copy and fixed https://github.com/mattermost/focalboard/issues/3131

* update cypress tests

* update default messages, en.json is created from default messages when running i18n-extract

* update tests for string changes

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
(cherry picked from commit 020d83fa44)

* clean up cherry-pick

* more cleanup

* fix bad merge

* fix cypress tests

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
2022-06-16 16:47:44 +05:30
Scott Bishel
5b309e8e25
updated/synced prior PR (#2509)
* updated/synced prior PR

* add title back for cypress tests

* update unit test for cypress fix

* move to function

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-03-10 14:39:13 -07:00
kamre
263e660604
Change wrapping of components in React.memo so that components have proper names in React Dev Tools. (#2332) 2022-02-14 13:55:13 -07:00
kamre
7cb25b9e17
[GH-1826] Cypress test for group by different property (#1966)
* Cypress command for resetting boards added.

* Cypress test for group board by different property added:
 - using @testing-library/cypress
 - minor fixes for `PropertyMenu` and `Dialog` components
 - bug in `ViewHeaderGroupByMenu` fixed: use `groupByProperty` passed in props instead of one from active view

* Jest snapshots updated.

* Use only case-sensitive strings for names in Cypress test.

* Cypress commands for adding new board and new group added.

* Jest snapshot for new test updated.

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-12-15 09:57:58 -07:00
kamre
c5a4dd80f7
[GH-705] Auto-name new property (#1408)
* Open menu with property name and type when new property is added.

* Adding new property asks for the type and sets initial name.

* Component for property types menu items introduced.

* Close property menu when enter is pressed in the input.

* Unit test for `CardDetailProperties` fixed:
 - jest snapshot updated
 - switched from mocking `fetch` to mocking `mutator`

* Unit tests for `CardDetailProperties` updated:
 - use the recommended way to get elements and trigger user events
 - test for properties menu when adding new property added

* Unit tests for `CardDetailProperties` added:
 - delete existing property
 - add new property

* Don't use debouncing for property type selection.

* Fix unit test for deleting property.

* Width of button `+ Add a property` is fixed.

* Jest snapshot updated after merge with `main`
2021-10-27 09:04:15 +02:00
Justine Geffen
b5053d982a
Update en.json - UI capitalization (#1178)
* Update en.json

Adjusted capitalization for UI text for consistency.

* Update webapp/i18n/en.json

* Apply suggestions from code review

* Propagating text the changes to the rest of the code

* Fix the snapshots

* Fixing cypress test

* Fixing table tests

Co-authored-by: Jesús Espino <jespinog@gmail.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
2021-09-14 17:28:39 +05:30
Harshil Sharma
e0ec1c03e0
New Props: Created By, Created At, Updated By, Updated At (#583)
* Added create_at column for blocks

* Populating created by

* Added logic for storing created by

* Added GetBlock by ID to store interface

* Added creayed by and modified by properties

* Added created by and modified by properties

* Added lastmodifiedat property

* Fixed existing webapp test

* Added webapp unit tests

* Added webapp unit tests

* Added webapp unit tests

* Adding server test

* Added server tests

* Fixed a bug causing created by to be set empty

* Avodining timezone specific test behavior

* Made cypress viewport bigger to avoid out-of-viewoport issues in multiple tests

* Removed a leftover comment

* Added updated at/by in table view

* Added updated at in card view

* Fixing sort

* Fixed sorting of updated by

* Fixed existing tests

* Added table tests

* Added cardTree fix

* Fixed tests

* Removed unused import

* Update snapshots

* Added a tamper attempt test

* Removed some leftover debug code

* Removed sending creator from client

* Fixed lint error

* Fixed a build issue

* Avoided setting insert query params multiple times

* Multiple minor review fixes

* Fixed test
2021-07-08 20:06:43 +05:30
Jesús Espino
aa80ac02af Importing only what is needed from lodash 2021-06-11 11:32:18 +02:00
Hossein
4d3d45323f
Card Template > Creating a property & setting type only stores either property name or type (#553)
* Fix bug

* update test and address comments

* Fix test

* Remove mousedown and use debounce

* Fix test

* fix lint
2021-06-11 11:22:19 +02:00
Harshil Sharma
90f6389745
Person Property Type (#406)
* Added getWorkspaceUsers API

* Integrated workspace user API in UI

* Integrated workspace user API in UI

* Added toto for implementation slot

* Implemenmted getWorkspaceUSers to get data from Focalboard DB

* Updated store mocks

* Made select styles a shared constant

* Removed unwanted diffs

* Removed unwanted diffs

* Updated snapshots for new property type

* Added user store test

* Added missing copyright notice

* Returning error if no users found to retain original behavior

* Minor fixes and added tests

* Minor fixes

* Used React context for workspace users

* Used useContext hook, and added additional user ID -> user context to avoid that computation by all componnets

* Mergerd both workspace user contextx

* Minor review fix
2021-06-04 18:53:15 +05:30
Hossein
e7126b1835
Implement Multi Select Values (#415) 2021-06-03 16:48:16 -04:00
Michael Kochell
1d87331391
Introduce checkbox property type (#439)
* introduce checkbox property type

* treat false as empty string

* Fixed lint issues

* Fixed webapp tests:

Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
2021-06-02 15:53:52 +05:30
Johannes Marbach
889794863a
[GH-315] Enable spell checking in inputs and markdown editor (#372)
* [GH-315] Enable spell checking in inputs and markdown editor

Relates to: #315

* Update snapshots
2021-05-10 17:17:10 +02:00
Jesús Espino
323f02f7ac Removing other unneeded injectIntl 2021-05-10 15:20:48 +02:00
Johannes Marbach
0f0d9f3bd8
[GH-38] Add date property (#391)
* [GH-38] Add date property

Closes: #38

* Add date menu item in snapshot to fix tests

* Add react-day-picker in NOTICE.txt
2021-05-10 07:46:07 +02:00
Bharat
97b446f609
Added phone number field (#286)
* Added phone number field

* Removed phone number validation since its a complicated problem to solve for now

* Added the missing case for phone
2021-04-27 12:34:58 +02:00
Bharat
e71e0c5ef1 Added URL as a property on the frontend 2021-04-01 18:56:42 +05:30
Chen-I Lim
e2a9597b78 Update PropertyMenu.Delete id 2021-03-31 14:19:12 -07:00
Bharat
bede81a921 Merged changes from main and ran extract 2021-04-01 02:14:02 +05:30
Jesús Espino
e441c4ee91 Migrating to property menu to functional component 2021-03-30 13:37:47 +02:00
Renjith
d6950c27bb Add property type email 2021-03-18 01:36:03 -05:00
Chen-I Lim
e35ba1abc5 Property Menu: i18n 2021-01-04 12:08:12 -08:00
Chen-I Lim
f0afce4197 Fix linting 2020-11-12 14:17:13 -08:00
Chen-I Lim
7ec73468c4 Make BoardPage state immutable 2020-11-09 10:04:07 -08:00
Chen-I Lim
0be3e36313 Fix build break 2020-11-03 11:15:16 -08:00
Jesús Espino
74de574525 Making propertyMenu a pure widget 2020-11-03 19:35:24 +01:00
Renamed from webapp/src/components/propertyMenu.tsx (Browse further)