luisgulo/focalboard
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Normalise and add safety checks to telemetry code (#1739)

Browse Source 
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
This commit is contained in:
Miguel de la Cruz 2021-11-03 18:46:51 +01:00 committed by GitHub
parent 02f7615c10
commit cee4b72261
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webapp/src/components/cardDialog.tsx
View File

@ -45,7 +45,7 @@ const CardDialog = (props: Props): JSX.Element => {
return
}
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.AddTemplateFromCard, {board: props.board.id, view: activeView.id, card: card.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.AddTemplateFromCard, {board: props.board.id, view: activeView.id, card: props.cardId})
await mutator.duplicateCard(
props.cardId,
intl.formatMessage({id: 'Mutator.new-template-from-card', defaultMessage: 'new template from card'}),
@ -70,7 +70,7 @@ const CardDialog = (props: Props): JSX.Element => {
Utils.assertFailure()
return
}
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DeleteCard, {board: props.board.id, view: props.activeView.id, card: card.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DeleteCard, {board: props.board.id, view: props.activeView.id, card: props.cardId})
await mutator.deleteBlock(card, 'delete card')
props.onClose()
}}

6
webapp/src/components/centerPanel.tsx
View File

@ -235,7 +235,7 @@ class CenterPanel extends React.Component<Props, State> {
const card = createCard()
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.CreateCard, {board: board.id, view: this.props.activeView.id, card: card.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.CreateCard, {board: board.id, view: activeView.id, card: card.id})
card.parentId = board.id
card.rootId = board.rootId
@ -275,7 +275,7 @@ class CenterPanel extends React.Component<Props, State> {
}
private addCardTemplate = async () => {
const {board} = this.props
const {board, activeView} = this.props
const cardTemplate = createCard()
cardTemplate.fields.isTemplate = true
@ -286,7 +286,7 @@ class CenterPanel extends React.Component<Props, State> {
cardTemplate,
'add card template',
async () => {
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.CreateCardTemplate, {board: board.id, view: this.props.activeView.id, card: cardTemplate.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.CreateCardTemplate, {board: board.id, view: activeView.id, card: cardTemplate.id})
this.props.addTemplate(cardTemplate)
this.showCard(cardTemplate.id)
}, async () => {

2
webapp/src/components/gallery/galleryCard.tsx
View File

@ -92,7 +92,7 @@ const GalleryCard = React.memo((props: Props) => {
id='duplicate'
name={intl.formatMessage({id: 'GalleryCard.duplicate', defaultMessage: 'Duplicate'})}
onClick={() => {
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DuplicateCard, {board: props.board.id, card: card.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DuplicateCard, {board: board.id, card: card.id})
mutator.duplicateCard(card.id)
}}
/>

2
webapp/src/components/kanban/kanbanCard.tsx
View File

@ -75,7 +75,7 @@ const KanbanCard = React.memo((props: Props) => {
id='duplicate'
name={intl.formatMessage({id: 'KanbanCard.duplicate', defaultMessage: 'Duplicate'})}
onClick={() => {
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DuplicateCard, {board: props.board.id, card: card.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DuplicateCard, {board: board.id, card: card.id})
mutator.duplicateCard(
card.id,
'duplicate card',

10
webapp/src/components/viewMenu.tsx
View File

@ -39,9 +39,9 @@ const ViewMenu = React.memo((props: Props) => {
}, [match, history])
const handleDuplicateView = useCallback(() => {
const {activeView} = props
const {board, activeView} = props
Utils.log('duplicateView')
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DuplicateBoardView, {board: props.board.id, view: activeView.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DuplicateBoardView, {board: board.id, view: activeView.id})
const currentViewId = activeView.id
const newView = createBoardView(activeView)
newView.title = `${activeView.title} copy`
@ -62,9 +62,9 @@ const ViewMenu = React.memo((props: Props) => {
}, [props.activeView, showView])
const handleDeleteView = useCallback(() => {
const {activeView, views} = props
const {board, activeView, views} = props
Utils.log('deleteView')
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DeleteBoardView, {board: props.board.id, view: activeView.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.DeleteBoardView, {board: board.id, view: activeView.id})
const view = activeView
const nextView = views.find((o) => o !== view)
mutator.deleteBlock(view, 'delete view')
@ -86,7 +86,7 @@ const ViewMenu = React.memo((props: Props) => {
const handleAddViewBoard = useCallback(() => {
const {board, activeView, intl} = props
Utils.log('addview-board')
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.CreateBoardView, {board: props.board.id, view: activeView.id})
TelemetryClient.trackEvent(TelemetryCategory, TelemetryActions.CreateBoardView, {board: board.id, view: activeView.id})
const view = createBoardView()
view.title = intl.formatMessage({id: 'View.NewBoardTitle', defaultMessage: 'Board view'})
view.fields.viewType = 'board'