luisgulo/focalboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

clean up code

Browse source
This commit is contained in:
Scott Bishel 2023-01-17 17:06:21 -07:00
parent 9d86216f5d
commit c69bc6c16d
1 changed files with 21 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
webapp/src/mutator.ts
View file

@ -665,26 +665,38 @@ class Mutator {
const newBlockIDs: string[] = []
if (propertyTemplate.type !== newType) {
// If the old type was either select/multiselect or person/multiperson
if (propertyTemplate.type === 'select' || propertyTemplate.type === 'multiSelect' ||
(propertyTemplate.type === 'person' || propertyTemplate.type === 'multiPerson')) { // If the old type was either select or multiselect
(propertyTemplate.type === 'person' || propertyTemplate.type === 'multiPerson')) {
// determine new type is either select/multiselect or person/multiperson
const isNewTypeSelectOrMulti = newType === 'select' || newType === 'multiSelect'
const isNewTypePersonOrMulti = newType === 'person' || newType === 'multiPerson'
const isOldTypeSelectOrMulti = newType === 'select' || newType === 'multiSelect'
const isOldTypePersonOrMulti = newType === 'person' || newType === 'multiPerson'
for (const card of cards) {
// if array get first value, if exists
const oldValue = Array.isArray(card.fields.properties[propertyTemplate.id]) ? (card.fields.properties[propertyTemplate.id].length > 0 && card.fields.properties[propertyTemplate.id][0] as string) : card.fields.properties[propertyTemplate.id] as string
if (oldValue) {
let newValue: string | undefined
if (isNewTypeSelectOrMulti) {
newValue = propertyTemplate.options.find((o) => o.id === oldValue)?.id
} else if (isNewTypePersonOrMulti) {
newValue = oldValue
} else if (propertyTemplate.type === 'select' || propertyTemplate.type === 'multiSelect') {
newValue = propertyTemplate.options.find((o) => o.id === oldValue)?.value
if (isOldTypePersonOrMulti) {
if (isNewTypePersonOrMulti) {
newValue = oldValue
}
} else if (isNewTypeSelectOrMulti) {
if (isOldTypeSelectOrMulti) {
newValue = propertyTemplate.options.find((o) => o.id === oldValue)?.id
} else {
newValue = propertyTemplate.options.find((o) => o.id === oldValue)?.value
}
}
const newCard = createCard(card)
if (newValue) {
newCard.fields.properties[propertyTemplate.id] = newType === 'multiSelect' ? [newValue] : newValue
if (newType === 'multiSelect' || newType === 'multiPerson') {
newCard.fields.properties[propertyTemplate.id] = [newValue]
} else {
newCard.fields.properties[propertyTemplate.id] = newValue
}
} else {
// This was an invalid select option or old person id, so delete it
delete newCard.fields.properties[propertyTemplate.id]