From 820cae6725a34ca813743436fc0727e3790eb8cc Mon Sep 17 00:00:00 2001
From: redhoyasa <redhoyasa@gmail.com>
Date: Mon, 31 Oct 2022 14:52:47 +0700
Subject: [PATCH 1/4] make view list disabled for readonly mode

---
 webapp/src/components/viewMenu.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/webapp/src/components/viewMenu.tsx b/webapp/src/components/viewMenu.tsx
index acb1dbf38..1d1536c35 100644
--- a/webapp/src/components/viewMenu.tsx
+++ b/webapp/src/components/viewMenu.tsx
@@ -279,6 +279,7 @@ const ViewMenu = (props: Props) => {
                             name={view.title}
                             icon={iconForViewType(view.fields.viewType)}
                             onClick={handleViewClick}
+                            disabled={props.readonly}
                         />))}
                 </div>
                 <BoardPermissionGate permissions={[Permission.ManageBoardProperties]}>

From 1da0abd7180a15b087185b7cbd72fce83101ec6c Mon Sep 17 00:00:00 2001
From: redhoyasa <redhoyasa@gmail.com>
Date: Mon, 7 Nov 2022 22:04:56 +0700
Subject: [PATCH 2/4] disable menu dropdown for readonly mode (#2932)

---
 webapp/src/components/viewHeader/viewHeader.tsx | 5 ++++-
 webapp/src/components/viewMenu.tsx              | 1 -
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/webapp/src/components/viewHeader/viewHeader.tsx b/webapp/src/components/viewHeader/viewHeader.tsx
index 95dc19652..2b7957cb2 100644
--- a/webapp/src/components/viewHeader/viewHeader.tsx
+++ b/webapp/src/components/viewHeader/viewHeader.tsx
@@ -150,7 +150,10 @@ const ViewHeader = (props: Props) => {
                     autoExpand={false}
                 />
                 <div>
-                    <MenuWrapper label={intl.formatMessage({id: 'ViewHeader.view-menu', defaultMessage: 'View menu'})}>
+                    <MenuWrapper
+                        disabled={props.readonly}
+                        label={intl.formatMessage({id: 'ViewHeader.view-menu', defaultMessage: 'View menu'})}
+                    >
                         <IconButton icon={<DropdownIcon/>}/>
                         <ViewMenu
                             board={board}
diff --git a/webapp/src/components/viewMenu.tsx b/webapp/src/components/viewMenu.tsx
index 1d1536c35..acb1dbf38 100644
--- a/webapp/src/components/viewMenu.tsx
+++ b/webapp/src/components/viewMenu.tsx
@@ -279,7 +279,6 @@ const ViewMenu = (props: Props) => {
                             name={view.title}
                             icon={iconForViewType(view.fields.viewType)}
                             onClick={handleViewClick}
-                            disabled={props.readonly}
                         />))}
                 </div>
                 <BoardPermissionGate permissions={[Permission.ManageBoardProperties]}>

From eb031cab5fb96594819f21d7f6d3f01891fa98cb Mon Sep 17 00:00:00 2001
From: redhoyasa <redhoyasa@gmail.com>
Date: Fri, 9 Dec 2022 16:41:36 +0700
Subject: [PATCH 3/4] hide dropdown for readonly mode

---
 webapp/src/components/viewHeader/viewHeader.tsx | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/webapp/src/components/viewHeader/viewHeader.tsx b/webapp/src/components/viewHeader/viewHeader.tsx
index 2b7957cb2..d8d5b4e1b 100644
--- a/webapp/src/components/viewHeader/viewHeader.tsx
+++ b/webapp/src/components/viewHeader/viewHeader.tsx
@@ -149,11 +149,8 @@ const ViewHeader = (props: Props) => {
                     spellCheck={true}
                     autoExpand={false}
                 />
-                <div>
-                    <MenuWrapper
-                        disabled={props.readonly}
-                        label={intl.formatMessage({id: 'ViewHeader.view-menu', defaultMessage: 'View menu'})}
-                    >
+                {!props.readonly && (<div>
+                    <MenuWrapper label={intl.formatMessage({id: 'ViewHeader.view-menu', defaultMessage: 'View menu'})}>
                         <IconButton icon={<DropdownIcon/>}/>
                         <ViewMenu
                             board={board}
@@ -164,7 +161,8 @@ const ViewHeader = (props: Props) => {
                         />
                     </MenuWrapper>
                     {showAddViewTourStep && <AddViewTourStep/>}
-                </div>
+                </div>)}
+
             </div>
 
             <div className='octo-spacer'/>

From 5450a298adfe587dca43778967b058667daf8b26 Mon Sep 17 00:00:00 2001
From: Rajat-Dabade <rajat.dabade@mattermost.com>
Date: Wed, 11 Jan 2023 23:52:51 +0530
Subject: [PATCH 4/4] Updated snapshot

---
 .../__snapshots__/centerPanel.test.tsx.snap   | 16 ----------
 .../__snapshots__/workspace.test.tsx.snap     | 30 -------------------
 .../__snapshots__/viewHeader.test.tsx.snap    | 16 ----------
 3 files changed, 62 deletions(-)

diff --git a/webapp/src/components/__snapshots__/centerPanel.test.tsx.snap b/webapp/src/components/__snapshots__/centerPanel.test.tsx.snap
index 49bf19dea..96d6ec147 100644
--- a/webapp/src/components/__snapshots__/centerPanel.test.tsx.snap
+++ b/webapp/src/components/__snapshots__/centerPanel.test.tsx.snap
@@ -2025,22 +2025,6 @@ exports[`components/centerPanel return centerPanel and press touch 1 with readon
             title="view title"
             value="view title"
           />
-          <div>
-            <div
-              aria-label="View menu"
-              class="MenuWrapper"
-              role="button"
-            >
-              <button
-                class="IconButton"
-                type="button"
-              >
-                <i
-                  class="CompassIcon icon-chevron-down DropdownIcon"
-                />
-              </button>
-            </div>
-          </div>
         </div>
         <div
           class="octo-spacer"
diff --git a/webapp/src/components/__snapshots__/workspace.test.tsx.snap b/webapp/src/components/__snapshots__/workspace.test.tsx.snap
index c1e09cb06..e371fc960 100644
--- a/webapp/src/components/__snapshots__/workspace.test.tsx.snap
+++ b/webapp/src/components/__snapshots__/workspace.test.tsx.snap
@@ -903,21 +903,6 @@ exports[`src/components/workspace return workspace readonly and showcard 1`] = `
                 title="view title"
                 value="view title"
               />
-              <div>
-                <div
-                  aria-label="View menu"
-                  class="MenuWrapper"
-                  role="button"
-                >
-                  <button
-                    type="button"
-                  >
-                    <i
-                      class="CompassIcon icon-chevron-down DropdownIcon"
-                    />
-                  </button>
-                </div>
-              </div>
             </div>
             <div
               class="octo-spacer"
@@ -2029,21 +2014,6 @@ exports[`src/components/workspace should match snapshot with readonly 1`] = `
                 title="view title"
                 value="view title"
               />
-              <div>
-                <div
-                  aria-label="View menu"
-                  class="MenuWrapper"
-                  role="button"
-                >
-                  <button
-                    type="button"
-                  >
-                    <i
-                      class="CompassIcon icon-chevron-down DropdownIcon"
-                    />
-                  </button>
-                </div>
-              </div>
             </div>
             <div
               class="octo-spacer"
diff --git a/webapp/src/components/viewHeader/__snapshots__/viewHeader.test.tsx.snap b/webapp/src/components/viewHeader/__snapshots__/viewHeader.test.tsx.snap
index daa39bf28..3d3279fb9 100644
--- a/webapp/src/components/viewHeader/__snapshots__/viewHeader.test.tsx.snap
+++ b/webapp/src/components/viewHeader/__snapshots__/viewHeader.test.tsx.snap
@@ -166,22 +166,6 @@ exports[`components/viewHeader/viewHeader return viewHeader readonly 1`] = `
         title="view title"
         value="view title"
       />
-      <div>
-        <div
-          aria-label="View menu"
-          class="MenuWrapper"
-          role="button"
-        >
-          <button
-            class="IconButton"
-            type="button"
-          >
-            <i
-              class="CompassIcon icon-chevron-down DropdownIcon"
-            />
-          </button>
-        </div>
-      </div>
     </div>
     <div
       class="octo-spacer"