Add integration tests for createBoard (#2632)

* Add integration tests for createBoard

* Update tests - no board access for nonmembers

* Fix TestCreateBoard

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

server/integrationtests/board_test.go

@@ -165,6 +165,28 @@ func TestCreateBoard(t *testing.T) {
 			require.Equal(t, board.ID, members[0].BoardID)
 			require.True(t, members[0].SchemeAdmin)
 		})
+
+		t.Run("creator should be able to access the public board and its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client.GetBoard(board.ID, "")
+			th.CheckOK(resp)
+			require.NotNil(t, rbBoard)
+			require.Equal(t, board, rbBoard)
+
+			rBlocks, resp := th.Client.GetBlocksForBoard(board.ID)
+			th.CheckOK(resp)
+			require.NotNil(t, rBlocks)
+		})
+
+		t.Run("A non-member user should be able to access the public board but not its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client2.GetBoard(board.ID, "")
+			th.CheckOK(resp)
+			require.NotNil(t, rbBoard)
+			require.Equal(t, board, rbBoard)
+
+			rBlocks, resp := th.Client2.GetBlocksForBoard(board.ID)
+			th.CheckForbidden(resp)
+			require.Nil(t, rBlocks)
+		})
 	})
 
 	t.Run("create private board", func(t *testing.T) {
@@ -173,7 +195,7 @@ func TestCreateBoard(t *testing.T) {
 
 		me := th.GetUser1()
 
-		title := "board title"
+		title := "private board title"
 		teamID := testTeamID
 		newBoard := &model.Board{
 			Title:  title,
@@ -198,13 +220,34 @@ func TestCreateBoard(t *testing.T) {
 			require.Equal(t, board.ID, members[0].BoardID)
 			require.True(t, members[0].SchemeAdmin)
 		})
+
+		t.Run("creator should be able to access the private board and its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client.GetBoard(board.ID, "")
+			th.CheckOK(resp)
+			require.NotNil(t, rbBoard)
+			require.Equal(t, board, rbBoard)
+
+			rBlocks, resp := th.Client.GetBlocksForBoard(board.ID)
+			th.CheckOK(resp)
+			require.NotNil(t, rBlocks)
+		})
+
+		t.Run("unauthorized user should not be able to access the private board or its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client2.GetBoard(board.ID, "")
+			th.CheckForbidden(resp)
+			require.Nil(t, rbBoard)
+
+			rBlocks, resp := th.Client2.GetBlocksForBoard(board.ID)
+			th.CheckForbidden(resp)
+			require.Nil(t, rBlocks)
+		})
 	})
 
 	t.Run("create invalid board", func(t *testing.T) {
 		th := SetupTestHelper(t).InitBasic()
 		defer th.TearDown()
 
-		title := "board title"
+		title := "invalid board title"
 		teamID := testTeamID
 		user1 := th.GetUser1()
 
@@ -256,6 +299,120 @@ func TestCreateBoard(t *testing.T) {
 	})
 }
 
+func TestCreateBoardTemplate(t *testing.T) {
+	t.Run("create public board template", func(t *testing.T) {
+		th := SetupTestHelper(t).InitBasic()
+		defer th.TearDown()
+
+		me := th.GetUser1()
+
+		title := "board template 1"
+		teamID := testTeamID
+		newBoard := &model.Board{
+			Title:      title,
+			Type:       model.BoardTypeOpen,
+			TeamID:     teamID,
+			IsTemplate: true,
+		}
+		board, resp := th.Client.CreateBoard(newBoard)
+		th.CheckOK(resp)
+		require.NoError(t, resp.Error)
+		require.NotNil(t, board)
+		require.NotNil(t, board.ID)
+		require.Equal(t, title, board.Title)
+		require.Equal(t, model.BoardTypeOpen, board.Type)
+		require.Equal(t, teamID, board.TeamID)
+		require.Equal(t, me.ID, board.CreatedBy)
+		require.Equal(t, me.ID, board.ModifiedBy)
+
+		t.Run("creating a board template should make the creator an admin", func(t *testing.T) {
+			members, err := th.Server.App().GetMembersForBoard(board.ID)
+			require.NoError(t, err)
+			require.Len(t, members, 1)
+			require.Equal(t, me.ID, members[0].UserID)
+			require.Equal(t, board.ID, members[0].BoardID)
+			require.True(t, members[0].SchemeAdmin)
+		})
+
+		t.Run("creator should be able to access the public board template and its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client.GetBoard(board.ID, "")
+			th.CheckOK(resp)
+			require.NotNil(t, rbBoard)
+			require.Equal(t, board, rbBoard)
+
+			rBlocks, resp := th.Client.GetBlocksForBoard(board.ID)
+			th.CheckOK(resp)
+			require.NotNil(t, rBlocks)
+		})
+
+		t.Run("another user should be able to access the public board template and its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client2.GetBoard(board.ID, "")
+			th.CheckOK(resp)
+			require.NotNil(t, rbBoard)
+			require.Equal(t, board, rbBoard)
+
+			rBlocks, resp := th.Client2.GetBlocksForBoard(board.ID)
+			th.CheckOK(resp)
+			require.NotNil(t, rBlocks)
+		})
+	})
+
+	t.Run("create private board template", func(t *testing.T) {
+		th := SetupTestHelper(t).InitBasic()
+		defer th.TearDown()
+
+		me := th.GetUser1()
+
+		title := "private board template title"
+		teamID := testTeamID
+		newBoard := &model.Board{
+			Title:      title,
+			Type:       model.BoardTypePrivate,
+			TeamID:     teamID,
+			IsTemplate: true,
+		}
+		board, resp := th.Client.CreateBoard(newBoard)
+		th.CheckOK(resp)
+		require.NotNil(t, board)
+		require.NotNil(t, board.ID)
+		require.Equal(t, title, board.Title)
+		require.Equal(t, model.BoardTypePrivate, board.Type)
+		require.Equal(t, teamID, board.TeamID)
+		require.Equal(t, me.ID, board.CreatedBy)
+		require.Equal(t, me.ID, board.ModifiedBy)
+
+		t.Run("creating a board template should make the creator an admin", func(t *testing.T) {
+			members, err := th.Server.App().GetMembersForBoard(board.ID)
+			require.NoError(t, err)
+			require.Len(t, members, 1)
+			require.Equal(t, me.ID, members[0].UserID)
+			require.Equal(t, board.ID, members[0].BoardID)
+			require.True(t, members[0].SchemeAdmin)
+		})
+
+		t.Run("creator should be able to access the private board template and its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client.GetBoard(board.ID, "")
+			th.CheckOK(resp)
+			require.NotNil(t, rbBoard)
+			require.Equal(t, board, rbBoard)
+
+			rBlocks, resp := th.Client.GetBlocksForBoard(board.ID)
+			th.CheckOK(resp)
+			require.NotNil(t, rBlocks)
+		})
+
+		t.Run("unauthorized user should not be able to access the private board template or its blocks", func(t *testing.T) {
+			rbBoard, resp := th.Client2.GetBoard(board.ID, "")
+			th.CheckForbidden(resp)
+			require.Nil(t, rbBoard)
+
+			rBlocks, resp := th.Client2.GetBlocksForBoard(board.ID)
+			th.CheckForbidden(resp)
+			require.Nil(t, rBlocks)
+		})
+	})
+}
+
 func TestGetAllBlocksForBoard(t *testing.T) {
 	th := SetupTestHelperWithToken(t).Start()
 	defer th.TearDown()