luisgulo/focalboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Gh 3953 remove channel link duplicate (#4011)

Browse source
This commit is contained in:
Scott Bishel 2022-10-17 15:45:51 -06:00 committed by GitHub
parent 2b984d45b2
commit 6f0c34ddd1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
server/services/store/sqlstore/boards_and_blocks.go
View file

@ -151,6 +151,7 @@ func (s *SQLStore) duplicateBoard(db sq.BaseRunner, boardID string, userID strin
board.Type = "P"
board.IsTemplate = asTemplate
board.CreatedBy = userID
board.ChannelID = ""
if toTeam != "" {
board.TeamID = toTeam

4
server/services/store/storetests/boards_and_blocks.go
View file

@ -582,7 +582,7 @@ func testDuplicateBoard(t *testing.T, store store.Store) {
newBab := &model.BoardsAndBlocks{
Boards: []*model.Board{
{ID: "board-id-1", TeamID: teamID, Type: model.BoardTypeOpen},
{ID: "board-id-1", TeamID: teamID, Type: model.BoardTypeOpen, ChannelID: "test-channel"},
{ID: "board-id-2", TeamID: teamID, Type: model.BoardTypePrivate},
{ID: "board-id-3", TeamID: teamID, Type: model.BoardTypeOpen},
},
@ -606,6 +606,7 @@ func testDuplicateBoard(t *testing.T, store store.Store) {
require.Len(t, bab.Boards, 1)
require.Len(t, bab.Blocks, 1)
require.Equal(t, bab.Boards[0].IsTemplate, false)
require.Equal(t, "", bab.Boards[0].ChannelID)
})
t.Run("duplicate existing board as template", func(t *testing.T) {
@ -615,6 +616,7 @@ func testDuplicateBoard(t *testing.T, store store.Store) {
require.Len(t, bab.Boards, 1)
require.Len(t, bab.Blocks, 1)
require.Equal(t, bab.Boards[0].IsTemplate, true)
require.Equal(t, "", bab.Boards[0].ChannelID)
})
t.Run("duplicate not existing board", func(t *testing.T) {