luisgulo/focalboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix typos in Webpack config and Makefile

Browse source
This commit is contained in:
Harrison Healey 2022-09-07 15:03:14 -04:00
parent 9c16d94854
commit 32f2d403e6
3 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Makefile
View file

@ -186,6 +186,7 @@ watch-plugin: modd-precheck ## Run and upload the plugin to a development server
live-watch-plugin: modd-precheck ## Run and update locally the plugin in the development server live-watch-plugin: modd-precheck ## Run and update locally the plugin in the development server
cd mattermost-plugin; make live-watch cd mattermost-plugin; make live-watch
.PHONY: watch-product
watch-product: ## Run the product as something the Mattermost web app will watch for watch-product: ## Run the product as something the Mattermost web app will watch for
cd mattermost-plugin; make watch-product cd mattermost-plugin; make watch-product

2
mattermost-plugin/Makefile
View file

@ -175,7 +175,7 @@ endif
deploy-from-watch: bundle deploy-from-watch: bundle
./build/bin/pluginctl deploy $(PLUGIN_ID) dist/$(BUNDLE_NAME) ./build/bin/pluginctl deploy $(PLUGIN_ID) dist/$(BUNDLE_NAME)
.PHONE: watch-product .PHONY: watch-product
watch-product: apply watch-product: apply
cd webapp && npm run start:product cd webapp && npm run start:product

12
mattermost-plugin/webapp/webpack.config.js
View file

@ -128,6 +128,7 @@ const config = {
}; };
if (TARGET_IS_PRODUCT) { if (TARGET_IS_PRODUCT) {
// Set up module federation
function makeSingletonSharedModules(packageNames) { function makeSingletonSharedModules(packageNames) {
const sharedObject = {}; const sharedObject = {};
@ -173,7 +174,16 @@ if (TARGET_IS_PRODUCT) {
} else { } else {
config.resolve.alias['react-intl'] = path.resolve(__dirname, '../../webapp/node_modules/react-intl/'); config.resolve.alias['react-intl'] = path.resolve(__dirname, '../../webapp/node_modules/react-intl/');
config.outputs = { config.externals = {
react: 'React',
redux: 'Redux',
'react-redux': 'ReactRedux',
'mm-react-router-dom': 'ReactRouterDom',
'prop-types': 'PropTypes',
'react-bootstrap': 'ReactBootstrap',
};
config.output = {
devtoolNamespace: PLUGIN_ID, devtoolNamespace: PLUGIN_ID,
path: path.join(__dirname, '/dist'), path: path.join(__dirname, '/dist'),
publicPath: '/', publicPath: '/',