luisgulo/Gitnuro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Removed use of keys in graph commits list

Browse source
This commit is contained in:
Abdelilah El Aissaoui 2022-10-23 18:05:20 +02:00
parent 2e0e616dc2
commit 5d7d1d6f8b
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/main/kotlin/com/jetpackduba/gitnuro/ui/log/Log.kt
View file

@ -382,7 +382,9 @@ fun MessagesList(
)
}
}
items(items = commitList, key = { it.name }) { graphNode ->
// Setting a key makes the graph preserve the scroll position when a new line has been added on top (uncommited changes)
// Therefore, after popping a stash, the uncommited changes wouldn't be visible and requires the user scrolling.
items(items = commitList) { graphNode ->
CommitLine(
graphWidth = graphWidth,
logViewModel = logViewModel,
@ -485,7 +487,7 @@ fun GraphList(
}
}
items(items = commitList, key = { it.name }) { graphNode ->
items(items = commitList) { graphNode ->
val nodeColor = colors[graphNode.lane.position % colors.size]
Row(